Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sharing): Do not create new share in guest app #1189

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Jun 24, 2024

Only create the template for share and return the the 'Sharing UI' in the sidebar

@Fenn-CS Fenn-CS force-pushed the fix/sharing-emit-event-4-new-share branch 2 times, most recently from a09bb9d to 4bb6956 Compare June 24, 2024 13:57
@Fenn-CS Fenn-CS changed the title WIP(Sharing): Emit event for newly created guest share fix(Sharing): Do not create new share in guest app Jun 24, 2024
Only create the template for share and return the the 'Sharing UI'
in the sidebar.

Signed-off-by: fenn-cs <[email protected]>
@Fenn-CS Fenn-CS force-pushed the fix/sharing-emit-event-4-new-share branch from 4bb6956 to 31f6ec8 Compare June 24, 2024 14:02
@Fenn-CS Fenn-CS marked this pull request as ready for review June 24, 2024 14:05
@Fenn-CS Fenn-CS requested a review from PVince81 June 24, 2024 14:05
@Fenn-CS Fenn-CS assigned susnux and artonge and unassigned susnux and artonge Jun 24, 2024
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Jun 24, 2024

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 24, 2024
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Jun 24, 2024

/backport to stable2.5

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Jun 24, 2024

/backport to stable2.4

@Fenn-CS Fenn-CS merged commit aa23b0a into master Jun 24, 2024
39 checks passed
@Fenn-CS Fenn-CS deleted the fix/sharing-emit-event-4-new-share branch June 24, 2024 17:13
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants